Volkor
/
SUpload
2
0
Fork 1
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Labels Milestones

Commiting readme.md changes for PR #2

Merged
Volkor merged 2 commits from domacikolaci/SUpload:master into master 1 month ago
Conversation 2 Commits 2 Files Changed 1
domacikolaci commented 2 months ago

As per issues #1, the PR for updating the readme.md file to make install process work + added a handy suggestion in configuration menu that made use of this program more user friendly and convenient as a Fedora user (should work for anyone on Gnome 3 however such as Ubuntu users)

As per issues #1, the PR for updating the readme.md file to make install process work + added a handy suggestion in configuration menu that made use of this program more user friendly and convenient as a Fedora user (should work for anyone on Gnome 3 however such as Ubuntu users)
Volkor requested changes 1 month ago
Dismissed
Volkor left a comment
Owner

Added a few comments, this is cool

Added a few comments, this is cool
README.md Outdated
@ -8,3 +8,3 @@
### Debian and Fedora based systems
[deb and rpm files are automatically generated for each version.](https://git.volkor.me/Volkor/SUpload/-/tags)
[deb and rpm files are automatically generated for each version.](https://git.volkor.me/domacikolaci/SUpload/releases)
Volkor commented 1 month ago
Owner

If you were forking this for your own project, this makes sense, but since you're getting this merged up, it should be https://git.volkor.me/Volkor/SUpload/releases

If you were forking this for your own project, this makes sense, but since you're getting this merged up, it should be `https://git.volkor.me/Volkor/SUpload/releases`
domacikolaci marked this conversation as resolved
README.md Outdated
@ -74,2 +74,4 @@
The default config is located at /etc/supload.conf, If it exists, it will read from ~/.config/supload/settings.conf. The home config file will take priority.
If you delete this file, it will **NOT** be recreated, you will have to recreate it.
If you are using the Gnome 3 desktop enviroment, you can add a custom shortcut to upload screenshots by going to Settings -> Keyboard -> View and Cusotmize Shortcuts -> Custom Shortcuts -> In your new shortcut, entre the command 'supload -sd https://youruploaddomain.com/'
Volkor commented 1 month ago
Owner

spell grammar for me :p

spell grammar for me :p
domacikolaci marked this conversation as resolved
domacikolaci requested review from Volkor 1 month ago
domacikolaci commented 1 month ago
Poster

Requested changes made <3

Requested changes made <3
Volkor refused to review 1 month ago
Volkor dismissed Volkor’s review 1 month ago
Reason:

for old commit, new commit is good

Volkor merged commit 478f86789d into master 1 month ago
Volkor referenced this issue from a commit 1 month ago
Commiting readme.md changes for PR (#2)
Volkor commented 1 month ago
Owner

\o/

\o/
The pull request has been merged as 478f86789d.
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b domacikolaci-master master
git pull master

Step 2:

Merge the changes and update on Gitea.
git checkout master
git merge --no-ff domacikolaci-master
git push origin master
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels
No items
No Label
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Set Project
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Volkor/SUpload#2
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'domacikolaci/SUpload:master'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes