Volkor
/
SUpload
2
0
Fork 1
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Commiting readme.md changes for PR #2

Merged
Volkor merged 2 commits from domacikolaci/SUpload:master into master 2023-02-21 10:11:29 +00:00
Conversation 2 Commits 2 Files Changed 1
domacikolaci commented 2023-02-06 13:16:46 +00:00

As per issues #1, the PR for updating the readme.md file to make install process work + added a handy suggestion in configuration menu that made use of this program more user friendly and convenient as a Fedora user (should work for anyone on Gnome 3 however such as Ubuntu users)

As per issues #1, the PR for updating the readme.md file to make install process work + added a handy suggestion in configuration menu that made use of this program more user friendly and convenient as a Fedora user (should work for anyone on Gnome 3 however such as Ubuntu users)
domacikolaci added 1 commit 2023-02-06 13:16:47 +00:00
Volkor requested changes 2023-02-21 08:59:09 +00:00
Dismissed
Volkor left a comment
Owner

Added a few comments, this is cool

Added a few comments, this is cool
README.md Outdated
@ -8,3 +8,3 @@
### Debian and Fedora based systems
[deb and rpm files are automatically generated for each version.](https://git.volkor.me/Volkor/SUpload/-/tags)
[deb and rpm files are automatically generated for each version.](https://git.volkor.me/domacikolaci/SUpload/releases)
Volkor commented 2023-02-21 08:58:17 +00:00
Owner

If you were forking this for your own project, this makes sense, but since you're getting this merged up, it should be https://git.volkor.me/Volkor/SUpload/releases

If you were forking this for your own project, this makes sense, but since you're getting this merged up, it should be `https://git.volkor.me/Volkor/SUpload/releases`
domacikolaci marked this conversation as resolved
README.md Outdated
@ -74,2 +74,4 @@
The default config is located at /etc/supload.conf, If it exists, it will read from ~/.config/supload/settings.conf. The home config file will take priority.
If you delete this file, it will **NOT** be recreated, you will have to recreate it.
If you are using the Gnome 3 desktop enviroment, you can add a custom shortcut to upload screenshots by going to Settings -> Keyboard -> View and Cusotmize Shortcuts -> Custom Shortcuts -> In your new shortcut, entre the command 'supload -sd https://youruploaddomain.com/'
Volkor commented 2023-02-21 08:58:44 +00:00
Owner

spell grammar for me :p

spell grammar for me :p
domacikolaci marked this conversation as resolved
domacikolaci requested review from Volkor 2023-02-21 09:52:17 +00:00
domacikolaci commented 2023-02-21 09:52:56 +00:00
Poster

Requested changes made <3

Requested changes made <3
domacikolaci added 1 commit 2023-02-21 09:54:30 +00:00
Volkor refused to review 2023-02-21 10:10:44 +00:00
Volkor dismissed Volkor’s review 2023-02-21 10:11:00 +00:00
Reason:

for old commit, new commit is good

Volkor merged commit 478f86789d into master 2023-02-21 10:11:29 +00:00
Volkor commented 2023-02-21 10:12:21 +00:00
Owner

\o/

\o/
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Volkor/SUpload#2
There is no content yet.
Delete Branch "domacikolaci/SUpload:master"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?